Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork and update guptarohit/asciigraph #1180

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

ploubser
Copy link
Collaborator

Here we fork guptarohit/asciigraph and add it to our internal packages.

We have added the ability to specify a ValueFormatter option for a graph, allowing us to prettify the lables shown on the y-axis of a graph.

With that we have added the ability to specify AlwaysY, which will force the graph to draw the y-axis even in cases where the input data is 0, allowing us to draw multiple graphs in the terminal with consistent size and clariy.

@ploubser ploubser force-pushed the asciigraph_updates branch 4 times, most recently from 522abc3 to 1a7c4ff Compare November 14, 2024 11:15
Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment otherwise good stuff

cli/server_graph_command.go Outdated Show resolved Hide resolved
Here we fork guptarohit/asciigraph and add it to our internal
packages.

We have added the ability to specify a `ValueFormatter` option
for a graph, allowing us to prettify the lables shown on the
y-axis of a graph.

With that we have added the ability to specify `AlwaysY`, which
will force the graph to draw the y-axis even in cases where
the input data is 0, allowing us to draw multiple graphs in
the terminal with consistent size and clariy.
Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ripienaar ripienaar merged commit 6b8199e into nats-io:main Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants